Fix semantic version check of camel-k-runtime #4731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🐫 Thank you for contributing! Code Coverage Report |
oscerd
approved these changes
Sep 12, 2023
squakez
requested changes
Sep 12, 2023
There was a problem hiding this comment.
With this PR we are removing at all the semver logic. The findBestMatch was used when you want to use a catalog which is not exactly known. For instance, running: kamel run test.yaml -t camel.runtime-version=3.x will get the latest 3.x catalog. This is particularly interesting now that we are independent from the runtime. However, we should include this feature in the doc and have an E2E test as well.
| @@ -483,6 +483,7 @@ func buildRuntimeBuilderImageSpectrum(options spectrum.Options) error { | |||
|
|
|||
| _, err := spectrum.Build(options, directories...) | |||
| if err != nil { | |||
| Log.Error(err, "Error trying to build Camel K builder container") | |||
There was a problem hiding this comment.
We are returning the error. The caller should know what to do with it, if printing a warning or what else.
|
Closing this in favor of #4741 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4715
kamel version -arelies on loading the catalog using the runtime provider, which is not set in the IntegrationPlatform object, so rendering null and not loading the CamelCatalog object.RuntimeVersiontype of CamelCatalog object to string, as there may be cases of the runtime version not following the semantic version.findBestMatchwas renamed tofindCatalog, since it was not actually trying to match a version rule, but plainly using a full version to check it.Release Note